Browser notifications

[Talisman_83]

 

I don't know how many times I've clicked the x just to close this, for it to reappear.. and reappear. Getting a bit tired of this.

Shouldn't there be a flag being set (true / false) to say whether a user has elected to have browser notifications enabled and allow an opt-in / out?

[Spider-Vice]

I haven't seen that pop-up since the first time I X'd out of it. Could be a cookie issue, try removing all your cookies for GTAForums, logging back in and seeing if it sticks.

[Talisman_83]

I could try that, but I'm guessing if whatever logic is still in place, after I delete my cookies, the pop-up will reappear and be added to my newly created cookie.

Will try though.

Edited November 29, 2019 by Talisman_83

[Spider-Vice]

Not necessarily, there could be some stuck cookie that doesn't register that you've closed the notification so it no longer appears and might be fixed by clearing your cookies. This cookie might be broken for you for example:

 

 

So I still suggest clearing them to eliminate that as a cause.  

[Talisman_83]

I did have that cookie set, value was true.

Deleted all, logged back in, will observe future behaviour.

 

Cheers Spider

 

[Talisman_83]

Ok, this is a bit mental..

 

Spoiler

 

1. It returned (note the time)

 

 

2. These were my cookies at that time, before did anything further.

 

 

3. I clicked the button to enable browser notifications. I didn't click X to close. These were my cookies after that event:

 

 

4. I pulled the tab into a new window as I wanted to focus on some comments on the Next DLC thread.

 

5. I replaced the window as a tab and it f*cking reappeared!

 

 

5. Cookies (I haven't clicked to enable or to X yet

 

 

 

 

 

 

PS - Checking front_front_core.js, perhaps this isn't being fired:

 

this.on(document, 'permissionDenied.notifications', this.hideNotice);

 

or possibly this piece of logic isn't correct or being fired:

 

dismissNotification: function(e) {
            if (e) {
                e.preventDefault();
            }
            var date = new Date();
            date.setDate(date.getDate() + 100);
            ips.utils.cookie.set('browserNotificationDismiss', true, date.toUTCString());
            this.scope.slideUp({
                duration: 400,
                complete: function() {
                    $(this).remove();
                }
            });
        }

[Talisman_83]

Follow-up:

 

I clicked X to close, refreshed the page and this appeared:

 

 

Surely this setting shouldn't be in a cookie with an expiry of a week from now?

Can the cookie expiry value not be set to 01-01-9999 or something?

Or perhaps don't store it at session-level and instead, add it as a flag on your profile?

Having it as a property on your member data would make more sense.

 

Just my 2 cents

[ṼirulenⱦEqừinox]

On 12/1/2019 at 5:59 PM, Talisman_83 said:

Follow-up:

 

I clicked X to close, refreshed the page and this appeared:

 

 

Surely this setting shouldn't be in a cookie with an expiry of a week from now?

Can the cookie expiry value not be set to 01-01-9999 or something?

Or perhaps don't store it at session-level and instead, add it as a flag on your profile?

Having it as a property on your member data would make more sense.

 

Just my 2 cents

What browser are you using?

 

I use Chrome and was given the option to Accept/Block notifications and once I selected Block it never appeared again

[Talisman_83]

8 hours ago, ṼirulenⱦEqừinox said:

What browser are you using?

 

I use Chrome and was given the option to Accept/Block notifications and once I selected Block it never appeared again

 

Safari, though its happened on Chrome too.

It goes away for a while, but then returns

Edited February 11, 2020 by Talisman_83

[Spider-Vice]

Has it happened recently? I think IPB has pushed some more updates related to this.

[Talisman_83]

44 minutes ago, Spider-Vice said:

Has it happened recently? I think IPB has pushed some more updates related to this.

Not for a while actually - I'll keep an eye on it and report back if it crops up again

Edited February 11, 2020 by Talisman_83

[ṼirulenⱦEqừinox]

12 hours ago, Talisman_83 said:

 

Safari, though its happened on Chrome too.

It goes away for a while, but then returns

Hmm weird but at least it looked to haves stopped for you.

 

I use safari on mobile and personally never  saw that box appear even when ad-blocker is turned off and the only thing I’ve gotten on PC via Chrome is the

Allow/Block notifications

box that pops up I clicked block and never saw it again