RDR2 Released ScriptHookRDR2

[Clipper95]

1 hour ago, MrXJKz said:

 

Instead of "can you fix it", maybe you can explain what is your problems? 

He's not God for reading in your mind.

there's nothing wrong with it..

it's just people think that if Josh's says something it's automatically correct, he even said there's nothing wrong with it

[Notex]

Not really too sure where to report bugs about Scripthook. But I found one that causes an issue if you try to unload/load a script using Ctrl + R. The script's filename can cause that to fail. Last night I was trying to troubleshoot all my code wondering why the script was failing to unload and I finally figured out the issue today. I renamed my script from MiniNPCs.asi to Pools.asi and script unloading/loading suddenly started working perfectly. I'm assuming there is some issue with having lowercase/uppercase/lowercase in the name that is causing this bug, but I figured I would post it here since I have no idea how else to contact you.

[Gesus]

I found a bug. After you finish a mission, new missions won't appear until you save and reload the savefile or travel somewhere by train.

Tested it with and without scripthook. No other scripts installed.

 

Can someone confirm this

[Alexander Blade]

CTRL+R reloading is exactly the same as before , if Windows refuses to unload your asi it means you have some resources locked , comment your code and test until os stops holding your library , also reloading doesn't undo the changes what the script did , if you set some flag like player's invincibility or unlim ammo which is usually a single native , this will stay in the game .

[jedijosh920]

2 hours ago, Alexander Blade said:

CTRL+R reloading is exactly the same as before , if Windows refuses to unload your asi it means you have some resources locked , comment your code and test until os stops holding your library , also reloading doesn't undo the changes what the script did , if you set some flag like player's invincibility or unlim ammo which is usually a single native , this will stay in the game .

@Alexander Blade Disabling this control still does not work:

CONTROLS::DISABLE_CONTROL_ACTION(0, joaat("INPUT_WHISTLE"), 0);

 

Also DISABLE_ALL_CONTROL_ACTIONS(0); does not disable that control for whatever reason.

Like I said it works for every other script hook except yours for now. Please fix this!

[TheRealLeve]

5 hours ago, jedijosh920 said:

@Alexander Blade Disabling this control still does not work:

CONTROLS::DISABLE_CONTROL_ACTION(0, joaat("INPUT_WHISTLE"), 0);

 

Also DISABLE_ALL_CONTROL_ACTIONS(0); does not disable that control for whatever reason.

Like I said it works for every other script hook except yours for now. Please fix this!

Glad to know its not just me having trouble with this

[machine4578]

anyone else having the minimap display extra large(even larger than expanded) when loading their game?? i have change the setting everytime to get it back to normal.

when i remove sripthook this never happens.

 

thanks again AB for this amazing mod!

 

Edited November 24, 2019 by machine4578

[Samuel0l]

is it possible to change the way to open the trainer? i mean change the f5 to something else..?

[elosarophar]

8 hours ago, Samuel0l said:

is it possible to change the way to open the trainer? i mean change the f5 to something else..?

Yes. It's defined in the scriptmenu.h file at line 215. Should look like the chunk of code below.

static bool MenuSwitchPressed()
{
	return IsKeyJustUp(VK_F5); // Change VK_F5 to VK_(whatever key you like)
}

Mostly straightforward key naming, but a list of built-in predefined keys are shown here on Microsoft docs if needed.

[Tiffany]

Is there a hotkey to immediately close the trainer windows? If you're in a window for like spawning a cougar you have to hit F5 like 3 times to get it out of the way.
 

Some things that would be nice:
• Fixing whatever it is that is making it so you have to save & reload the game after every mission because all the missions disappear when the trainer's active. I'd probably put this one at the highest priority cause it's real annoying.
• Adding the missing weapons like the M1899 Pistol, Evans Repeater, High Roller Revolver, Le Mat Revolver, ornate dagger, etc.
• Being able to spawn male or female horses (since it seems to only spawn males).
• Being able to spawn wild horses so that you can break them for the quest.
• Being able to spawn plants that you can then harvest for quests or just if needed.
• Fixing the vehicle boost so it actually makes horses go faster. For whatever reason this doesn't work at all for me.
• Add a cheat to increase horse bonding (maybe even including the flags that unlock the greyed out stats you get increased for winning 2 races against strangers).
• Add a cheat to increase weapon familiarity.
• Add something for infinite items and infinite ammo (other than just no reload), and fix the no reload script so it works after you unlock dual wielding which seems to break it.
• Add something that lets you duplicate items or set an item's number. Like adjust the quantity of the currently selected item.
• Have a setting for the script hook to remember your settings so it automatically puts everything on after you reload a save, or reopen the game.
• Some kind of flags to unlock New Austin & Blackwater so Arthur can go there and the legendary animals and such there will spawn. Also maybe some flags to unlock it so stuff like the legendary gator can spawn before "That's Murfree Country" in Chapter 6.
• Maybe add some horses like Buel & Rachel that you could spawn. Maybe even that Black Chestnut Thoroughbred that's only available in Online.

• Maybe some kinda setting to permanently adjust the stats of your currently mounted horse so you could increase the speed, bonding, health, stamina, temperament (like how War horses won't buck you off generally).
• Maybe make lions spawnable... idk if they could actually attack people though, or if it's just a single scripted attack.

• Add some kind of settings to adjust hair/facial hair length & styles.

• Add some kind of setting so the weapons of your choice are auto equipped or it keeps them equipped, cause it's annoying constantly having to select them or losing them if you have to retry from a checkpoint. I imagine like you select whatever gear you want, then in the menu select something to lock weapon selection. Then from then on it'll keep them equipped for you. Or maybe have 2 different settings. Like one where it keeps them on, or another where you can just open or set a key to put them back. That way in the instance you might want to change them yourself it'll be fine, but you can easily get back to the preferred setup.

Also potentially totally beyond the scope of a trainer... it'd be nice if someone made a mod at some point that removed Arthur getting

Spoiler

Tuberculosis

and

Spoiler

dying.

Which I guess would just involve removing whatever flag makes him

Spoiler

cough and reduces his stats

And removing and/or editing the cutscenes that involve it.

 

Then after the end just have him...

Spoiler

get back up and say some random line (which there's audio files for) and limp away into the sunset. Maybe even limp back down to his horse and give it a horse reviver, then ride away into the sunset.

 

[elosarophar]

3 hours ago, Tiffany said:

Is there a hotkey to immediately close the trainer windows? If you're in a window for like spawning a cougar you have to hit F5 like 3 times to get it out of the way.

Not as far as I can tell. But, I was able to implement the functionality into it. I'm not much of a programmer. Here's what I did though...

 

In scriptmenu.h

struct MenuInputButtonState
{
	bool a, b, up, down, l, r, menu; // Added 'menu' to separate it from the 'b' state
};

class MenuInput
{
public:
	...
	static MenuInputButtonState GetButtonState()
	{
		return {
			IsKeyDown(VK_NUMPAD5) || (IsKeyDownLong(VK_CONTROL) && IsKeyDown(VK_RETURN)),
			IsKeyDown(VK_NUMPAD0) || IsKeyDown(VK_BACK), // Moved MenuSwitchPressed() to end of state list
			IsKeyDown(VK_NUMPAD8) || (IsKeyDownLong(VK_CONTROL) && IsKeyDown(VK_UP)),
			IsKeyDown(VK_NUMPAD2) || (IsKeyDownLong(VK_CONTROL) && IsKeyDown(VK_DOWN)),
			IsKeyDown(VK_NUMPAD6) || (IsKeyDownLong(VK_CONTROL) && IsKeyDown(VK_RIGHT)),
			IsKeyDown(VK_NUMPAD4) || (IsKeyDownLong(VK_CONTROL) && IsKeyDown(VK_LEFT)),
			MenuSwitchPressed()
		};
	}
	...
};

 

In scriptmenu.cpp

if (buttons.a || buttons.b || buttons.up || buttons.down || buttons.menu) // Added menu to conditional check
{
	MenuInput::MenuInputBeep();
	// Not sure about this part but since the open menu was part of 'b', I added 'menu' here
	waitTime = buttons.b || buttons.menu ? 200 : 150;
}

if (buttons.a)
...
// Added functionality for 'menu' state to close out all active menus
else if (buttons.menu)
{
	auto controller = GetController();
	while (controller->HasActiveMenu())
		controller->PopMenu();
}

 

Note:  If this code is meant to support both keyboard and game controller, I don't have a game controller to verify how the new menu state works. This is only tested on keyboard.

Edited November 25, 2019 by elosarophar
typo, code correction

[Samuel0l]

7 hours ago, elosarophar said:

Yes. It's defined in the scriptmenu.h file at line 215. Should look like the chunk of code below.

static bool MenuSwitchPressed()
{
	return IsKeyJustUp(VK_F5); // Change VK_F5 to VK_(whatever key you like)
}

Mostly straightforward key naming, but a list of built-in predefined keys are shown here on Microsoft docs if needed.

thanks man but i cannot find this file..

it's in the devs version?

[elosarophar]

13 minutes ago, Samuel0l said:

thanks man but i cannot find this file..

it's in the devs version?

Yeah, it's the SDK files. For the SDK solution, what I did was...

1. Install Visual Studio 2019 Community Edition with the "Desktop Development with C++" workload
2. Open the "samples\NativeTrainer.sln" solution file with Visual Studio
3. It will ask you to upgrade the solution. I accepted the upgrade default options. (if you did a fresh new VS install, you may be asked other questions)
4. Once opened, from menu choose Build → Build Solution. You will get some warnings in log window, but it should report something like the following...
   1. "1>NativeTrainer.vcxproj -> \ScriptHookRDR2_SDK\samples\NativeTrainer\bin\Release\NativeTrainer.asi
      ========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========".
5. This will build NativeTrainer.asi at "<solution directory>\NativeTrainer\bin\Release", which then you can copy to the RDR2 exe folder.

If you have questions about this process, feel free to ask.

[UpTheDowngrade]

Is the newest version of rdr2, 1207.77 supported?

Edited November 26, 2019 by UpTheDowngrade

[kay0]

51 minutes ago, UpTheDowngrade said:

Is the newest version of rdr2, 1207.77 supported?

yes

[huntsman345]

I would have to disagree... running this on 1207.77 results in the saved not loading and a game error rerquiring a restart. Removing the script hook files from the game folder resolves the issue.

[Tiffany]

5 hours ago, huntsman345 said:

I would have to disagree... running this on 1207.77 results in the saved not loading and a game error rerquiring a restart. Removing the script hook files from the game folder resolves the issue.

It's working fine for me. You should maybe make sure you're using the latest version rather than the initial version posted.

[huntsman345]

2 hours ago, Tiffany said:

It's working fine for me. You should maybe make sure you're using the latest version rather than the initial version posted.

Downloaded from AB's site, the 20th Nov update. Still no joy

[Tiffany]

Bug report: When you add honor it spawns a shopkeeper to attack you.

1 hour ago, huntsman345 said:

Downloaded from AB's site, the 20th Nov update. Still no joy

Dunno what to tell you. I'm using ScriptHookRDR2_1.0.1207.73 and it works perfectly still.

 

I'm using the Rockstar game launcher. Are you using something different? Could be the difference maybe... I dunno.

[Andrea_23]

On 11/9/2019 at 9:25 AM, Alexander Blade said:

SCRIPT HOOK RDR 2

Note:
Script hook uses address autosearch, which means it will work with game versions which are not mentioned here until the game update with changes to the script system.
    
Description:
Script hook is the library that allows to use RDR 2 script native functions in custom *.asi plugins.
    

Multiplayer:
Script hook closes the game when player goes Online, this is done because the game reports installed mods list to R* while being in Online mode.

Installation:
1. Copy ScriptHookRDR2.dll to the game's main folder, i.e. where RDR2.exe is located.
2. In order to load asi plugins you need to have asi loader installed, you can use the latest version that comes with this distrib (dinput8.dll).
3. This distrib also includes a sample asi plugin - native trainer, if you need a trainer then copy NativeTrainer.asi as well.
   
Supported game versions:
1.0.1207.58, 1.0.1207.60, 1.0.1207.69, 1.0.1207.73

DOWNLOAD


NATIVE TRAINER

  Reveal hidden contents

 

Description:            
The trainer comes with this distrib and shows an example of what can be done using scripts.

Controls:

F5                                                               activate
NUM2/8                 (CTRL+UP/DOWN)        navigate thru the menus and lists                                        
NUM5                    (CTRL+ENTER)             select
NUM0/BACKSPACE/F5                                back
NUM9/3                 (PAGEUP/DOWN)           use vehicle boost when active
NUM+                    (INSERT)                        use transport guns

In order num keys to work numlock must be on.

 
The trainer:

 - player
     - transport
         - invincible horse
         - unlim horse stamina
         - vehicle boost
     - skins
         - animals
         - peds
     - teleport
         - map marker
         - various locations        
     - wanted
         - clear bounty
         - clear wanted
         - never wanted
     - fix player
     - add cash
     - fast heal
     - invincible
     - unlim stamina
     - unlim ability
     - everyone ignored
     - noiseless
     - super jump
 - animal spawner
     - random
     - horses
     - dogs
     - fish
     - other animals
 - ped spawner
     - random
     - cutscene
     - other peds
 - cannon spawner
     - wrap in spawned
     - set properly
     - all cannons
 - vehicle spawner
     - wrap in spawned
     - set properly
     - boats
     - trains
     - wagons
     - just wagons
     - misc
 - weapon
     - get all weapon
     - powerfull guns
     - powerfull melee
     - no reload
     - drop current
 - time
     - hour forward
     - hour backward
     - clock paused
     - clock real
     - sync with system
 - weather
     - freeze current
     - fast wind
     - select weather
 - misc
     - reveal map
     - add honor
     - hide hud
     - horse turrets
     - horse cannons
     - vehicle turrets
     - vehicle cannons

 

 

 

Hi Alexander, thank you for your effort!

I report you that there is a bug in ScriptHook that causes quests to disappear from the map until the game is either reloaded, or you go to sleep. Can you check this issue?

Edited November 26, 2019 by Andrea_23

[Gesus]

4 hours ago, Andrea_23 said:

 

Hi Alexander, thank you for your effort!

I report you that there is a bug in ScriptHook that causes quests to disappear from the map until the game is either reloaded, or you go to sleep. Can you check this issue?

Hey I might have found a fix for this bug. Do either a clean Windows boot (check youtube) or go into your windows services and deactivate "Rockstar Game Library Service" and activate it again. While the Rockstar Games Launcher is closed.

Could you confirm this?

[anhkmorpork]

Not so much a bug as a miss labling, but the bighornram spawns in a big horn sheep, and the elk and moose spawns are also female. Males are needed for the camp upgrades.

[EeK9X]

Ever since RDR2's penultimate patch, teleporting to a marker location often causes the game to freeze and CTD.

 

It happens about 80% of the time after teleporting to a marker location, before all assets and textures even finish loading.

 

I'm using the latest version of ScriptHook. Anyone else experiencing the same issue? Teleporting is one of the most useful features, to me. Sucks not being able to use it.

[Tiffany]

13 hours ago, EeK9X said:

Ever since RDR2's penultimate patch, teleporting to a marker location often causes the game to freeze and CTD.

 

It happens about 80% of the time after teleporting to a marker location, before all assets and textures even finish loading.

 

I'm using the latest version of ScriptHook. Anyone else experiencing the same issue? Teleporting is one of the most useful features, to me. Sucks not being able to use it.

I teleported around quite a lot yesterday as per usual, including down around Tumbleweed with Arthur to hunt & kill the Legendary Tatanka Bison.

 

I did try to launch the game before updating to .77 though cause some people in this thread had me paranoid the trainer would break, using a command line so it'd start in offline mode. Interestingly enough though, the game refuses to launch from the launcher in offline mode. Play just greys out after clicked then after a few seconds comes back and can be clicked again. Ended up just biting the bullet & letting it update, and it still worked for me anyways. Probably not all that relevant to your issue, but if someone else reads it and is concerned about preventing their game from updating so they don't have to chance it, it might help them. Or at least save them a minute of their time.

[LCstuntman]

On 11/23/2019 at 9:37 AM, Alexander Blade said:

CTRL+R reloading is exactly the same as before , if Windows refuses to unload your asi it means you have some resources locked , comment your code and test until os stops holding your library , also reloading doesn't undo the changes what the script did , if you set some flag like player's invincibility or unlim ammo which is usually a single native , this will stay in the game .

Sorry for being off-topic but your PMs are full. Do you have any plans on releasing the source code for GTA Android CLEO? I'd like to try and update it for the latest game versions. Thanks!

[Flying Scotsman]

On 11/19/2019 at 3:53 AM, GN 92 said:

I hope the creators of the GTAV Enhanced native trainer create a RDR2 version

We're working on it.

[XaeroDegreaz]

@Alexander Blade 

 

Firstly, thank you for your work on this.

 

Is there any support for toggling the first-person camera via your API? Native calls to 

_RENDER_FIRST_PERSON_CAM = 10123106764729504083, // 0x8C7C7FF7CF0E5153

seem not to work. What I've observed is that when in 3rd person camera view, and you invoke that address with true | false, the camera will snap to an odd rotation, but you'll still be in 3rd person. If you supply false while in 1st person mode, nothing happens.

I feel like the process for which RDR2 switches between 1st, and 3rd person cameras may be a little different than GTA5; I've noticed that while in 1st person mode, the player tends to always lightly run, whereas in order to get the same effect in 3rd person mode you have to tap shift once.

 

It would be nice to be able to programmatically control entering and exiting 1st person -- I hate to have to manually switch when mounting, dismounting my horse (c'mon Rockstar give us separate camera options!).

 

I've looked at your documentation at https://www.dev-c.com/nativedb/ns/CAM, which shows

Quote

CAM::_RENDER_FIRST_PERSON_CAM

Hashes: 0xC819F3CBB62BF692 0xD3C08183

---

void _RENDER_FIRST_PERSON_CAM(BOOL render, float p1, int p2)
// 0xC819F3CBB62BF692 0xD3C08183

---

This native makes the gameplay camera zoom into first person/third person with a special effect.

For example, if you were first person in a mission and after the cutscene ends, the camera would then zoom into the first person camera view.

if (CAM::GET_FOLLOW_PED_CAM_VIEW_MODE() != 4)
CAM::_C819F3CBB62BF692(1, 0, 3, 0)

This makes the camera zoom in to first person.

--------------------------------------------
1st Param Options: 0 or 1 (Changes quit often, toggle?)
2nd Param Options: 0, 0f, 1f, 3.8f, 10f, 20f (Mostly 0)
3rd Param Options: 3, 2, 1 (Mostly 3);
Note for the 2nd param 10f (offroad_race.c) and 3rd param 20f (range_modern.c) are the only times those 2 high floats are called.
Note for the 3rd param 2 is only ever set in (franklin0.c), but it also sets it as 3. (0, 0, 3) ||(0, 0f, 2) || (0, 0, 3)

but it seems this documentation is for GTAV (I noticed the addresses were different, but I thought I'd give it a shot anyhow).

 

Thanks in advance if you've taken the time to look at my post.

[schoolofmonkey]

On 11/27/2019 at 6:27 AM, Andrea_23 said:

 

Hi Alexander, thank you for your effort!

I report you that there is a bug in ScriptHook that causes quests to disappear from the map until the game is either reloaded, or you go to sleep. Can you check this issue?

Hi, I'm getting the same.

Happens after a completing a mission, catching the train, carriage, sleeping or camping seems to have the next missions reappear on the map again.

Well all that or just reload a save game.

 

The suggested fix of clean windows boot or stopping and starting the Rockstar Game Library Service doesn't do anything..

 

I'm new here, but I've been using scripthook for a while in previous game..lol..

[Reese5493]

Has anyone encountered a problem that after installing Script Hook RDR2, the control sticks and the keys either do not respond or respond with a huge delay?
Installed:
Script Hook RDR2 (C ++ ScriptHookRDR2 by Alexander Blade) http://www.dev-c.com/rdr2/scripthookrdr2/
Community ScriptHookRDR2 .NET https://www.nexusmods.com/reddeadredemption2/mods/70?tab= description
1 shot 1 kill mod https://www.nexusmods.com/reddeadredemption2/mods/92

[AlwaysKaffaNL]

On 11/25/2019 at 5:06 AM, Tiffany said:

Is there a hotkey to immediately close the trainer windows? If you're in a window for like spawning a cougar you have to hit F5 like 3 times to get it out of the way.
 

Some things that would be nice:
• Fixing whatever it is that is making it so you have to save & reload the game after every mission because all the missions disappear when the trainer's active. I'd probably put this one at the highest priority cause it's real annoying.
• Adding the missing weapons like the M1899 Pistol, Evans Repeater, High Roller Revolver, Le Mat Revolver, ornate dagger, etc.
• Being able to spawn male or female horses (since it seems to only spawn males).
• Being able to spawn wild horses so that you can break them for the quest.
• Being able to spawn plants that you can then harvest for quests or just if needed.
• Fixing the vehicle boost so it actually makes horses go faster. For whatever reason this doesn't work at all for me.
• Add a cheat to increase horse bonding (maybe even including the flags that unlock the greyed out stats you get increased for winning 2 races against strangers).
• Add a cheat to increase weapon familiarity.
• Add something for infinite items and infinite ammo (other than just no reload), and fix the no reload script so it works after you unlock dual wielding which seems to break it.
• Add something that lets you duplicate items or set an item's number. Like adjust the quantity of the currently selected item.
• Have a setting for the script hook to remember your settings so it automatically puts everything on after you reload a save, or reopen the game.
• Some kind of flags to unlock New Austin & Blackwater so Arthur can go there and the legendary animals and such there will spawn. Also maybe some flags to unlock it so stuff like the legendary gator can spawn before "That's Murfree Country" in Chapter 6.
• Maybe add some horses like Buel & Rachel that you could spawn. Maybe even that Black Chestnut Thoroughbred that's only available in Online.

• Maybe some kinda setting to permanently adjust the stats of your currently mounted horse so you could increase the speed, bonding, health, stamina, temperament (like how War horses won't buck you off generally).
• Maybe make lions spawnable... idk if they could actually attack people though, or if it's just a single scripted attack.

• Add some kind of settings to adjust hair/facial hair length & styles.

• Add some kind of setting so the weapons of your choice are auto equipped or it keeps them equipped, cause it's annoying constantly having to select them or losing them if you have to retry from a checkpoint. I imagine like you select whatever gear you want, then in the menu select something to lock weapon selection. Then from then on it'll keep them equipped for you. Or maybe have 2 different settings. Like one where it keeps them on, or another where you can just open or set a key to put them back. That way in the instance you might want to change them yourself it'll be fine, but you can easily get back to the preferred setup.

Also potentially totally beyond the scope of a trainer... it'd be nice if someone made a mod at some point that removed Arthur getting

  Reveal hidden contents

Tuberculosis

and

  Reveal hidden contents

dying.

Which I guess would just involve removing whatever flag makes him

  Reveal hidden contents

cough and reduces his stats

And removing and/or editing the cutscenes that involve it.

 

Then after the end just have him...

  Reveal hidden contents

get back up and say some random line (which there's audio files for) and limp away into the sunset. Maybe even limp back down to his horse and give it a horse reviver, then ride away into the sunset.

 

Dude why the f*ck do you want alexander to work on a native trainer that is ment as an example.
His entire project is designed so other people can work on menu's
Stop asking stupid stuff from this guy just let him work on the nativedb.