[SA][C++]CCopPed Constructor Patch

[B1ack_Wh1te]

Hi.

How do I patch the CCopPed constructor?

I wrote the code, but the game crashes.

#include "plugin.h"
#include "CStreaming.h"

using namespace plugin;

void _CPed(CPed *obj, ePedType pedType) {
	((void (__thiscall *)(CPed *, ePedType))0x5E8030)(obj, pedType);
}

void CAEPedSpeechAudioEntity_Init(CAEPedSpeechAudioEntity *obj, CPed *ped) {
	((void (__thiscall *)(CAEPedSpeechAudioEntity *, CPed *))0x4E68D0)(obj, ped);
}

void _CCopPed(CCopPed *copPed, eCopType copType)
{
	_CPed(copPed, PED_TYPE_COP);
	copPed->m_copType = copType;
	switch (copType) {
	case COP_TYPE_CITYCOP:
		copPed->SetModelIndex(CStreaming::GetDefaultCopModel());
		copPed->GiveWeapon(WEAPON_NIGHTSTICK, 1000, true);
		copPed->GiveDelayedWeapon(WEAPON_PISTOL, 1000);
		copPed->m_nActiveWeaponSlot = 0;
		copPed->m_fArmour = 0.0f;
		copPed->m_nWeaponShootingRate = 30;
		copPed->m_nWeaponAccuracy = 60;
		break;
	case COP_TYPE_LAPDM1:
		copPed->SetModelIndex(MODEL_LAPDM1);
		copPed->GiveWeapon(WEAPON_NIGHTSTICK, 1000, true);
		copPed->GiveDelayedWeapon(WEAPON_PISTOL, 1000);
		copPed->m_nActiveWeaponSlot = 0;
		copPed->m_fArmour = 0.0f;
		copPed->m_nWeaponShootingRate = 30;
		copPed->m_nWeaponAccuracy = 60;
		break;
	case COP_TYPE_SWAT1:
	case COP_TYPE_SWAT2:
		copPed->SetModelIndex(MODEL_SWAT);
		copPed->GiveDelayedWeapon(WEAPON_MICRO_UZI, 1000);
		copPed->SetCurrentWeapon(WEAPON_MICRO_UZI);
		copPed->m_fArmour = 50.0f;
		copPed->m_nWeaponShootingRate = 70;
		copPed->m_nWeaponAccuracy = 68;
		break;
	case COP_TYPE_FBI:
		copPed->SetModelIndex(MODEL_FBI);
		copPed->GiveDelayedWeapon(WEAPON_MP5, 1000);
		copPed->SetCurrentWeapon(WEAPON_MP5);
		copPed->m_fArmour = 100.0f;
		copPed->m_nWeaponShootingRate = 60;
		copPed->m_nWeaponAccuracy = 76;
		break;
	case COP_TYPE_ARMY:
		copPed->SetModelIndex(MODEL_ARMY);
		copPed->GiveDelayedWeapon(WEAPON_M4, 1000);
		copPed->SetCurrentWeapon(WEAPON_M4);
		copPed->m_fArmour = 100.0f;
		copPed->m_nWeaponShootingRate = 80;
		copPed->m_nWeaponAccuracy = 84;
		break;
	case COP_TYPE_CSHER:
		copPed->SetModelIndex(MODEL_CSHER);
		copPed->GiveWeapon(WEAPON_NIGHTSTICK, 1000, true);
		copPed->GiveDelayedWeapon(WEAPON_PISTOL, 1000);
		copPed->m_nActiveWeaponSlot = 0;
		copPed->m_fArmour = 0.0f;
		copPed->m_nWeaponShootingRate = 30;
		copPed->m_nWeaponAccuracy = 60;
		break;
	default:
		copPed->SetModelIndex(copType);
		copPed->GiveWeapon(WEAPON_NIGHTSTICK, 1000, true);
		copPed->GiveDelayedWeapon(WEAPON_PISTOL, 1000);
		copPed->m_nActiveWeaponSlot = 0;
		copPed->m_fArmour = 0.0f;
		copPed->m_nWeaponShootingRate = 30;
		copPed->m_nWeaponAccuracy = 60;
	}
	copPed->field_79C = 0;
	copPed->field_74C = 0;
	copPed->field_7A4 = 0;
		CEntity *ent = copPed->m_pTargetedObject;
		if (copPed->m_pTargetedObject)
			copPed->m_pTargetedObject->CleanUpOldReference(&ent);
	copPed->m_pTargetedObject = nullptr;
	CAEPedSpeechAudioEntity_Init(&copPed->m_pedSpeech, copPed);
	copPed->m_pIntelligence->m_fDmRadius = 60.0f;
	copPed->m_pIntelligence->m_nDmNumPedsToScan = 8;

	copPed->m_pCopPartner = 0;
	copPed->m_apCriminalsToKill[0] = 0;
	copPed->m_apCriminalsToKill[1] = 0;
	copPed->m_apCriminalsToKill[2] = 0;
	copPed->m_apCriminalsToKill[3] = 0;
	copPed->m_apCriminalsToKill[4] = 0;
	copPed->field_7C0 = 0;
}

class _CopPed {
public:
	_CopPed() {
		Events::gameProcessEvent += [] {
			patch::RedirectJump(0x5DDC60, _CCopPed);
		};
    }
} _copPed;

What have I done wrong?

[PCjero]

I don't know (because i don't know nothing of coding (except Sanny Builder)), but what are you trying to do my friend?

[B1ack_Wh1te]

On 12/1/2018 at 11:28 AM, Gh1baudi said:

I don't know (because i don't know nothing of coding (except Sanny Builder)), but what are you trying to do my friend?

I want to rewrite the CCopPed class constructor to edit it later. This constructor is installing the model for the police.

[PCjero]

What do you mean by installing the model of the police? Different Cops models?

[B1ack_Wh1te]

7 hours ago, Gh1baudi said:

What do you mean by installing the model of the police?

I mean, setting up a model id for a cop.

7 hours ago, Gh1baudi said:

Different Cops models?

Yes, I want the SWAT to have 2 models, not just one (285). To do this, I need to change other functions, but first I need to rewrite the constructor for the original code.

[The Hero]

Your ctor has to be a thiscall.

[B1ack_Wh1te]

Thanks, I wrote the constructor under thiscall, but the game still crashes.

// CCopPed.h

void _CCopPed(eCopType copType) {
	((void (__thiscall *)(CPed *, ePedType))0x5E8030)(this, PED_TYPE_COP); // CPed::CPed(PED_TYPE_COP);
	this->m_copType = copType;
	switch (copType) {
	case COP_TYPE_CITYCOP:
		this->SetModelIndex(CStreaming::GetDefaultCopModel());
		this->GiveWeapon(WEAPON_NIGHTSTICK, 1000, true);
		this->GiveDelayedWeapon(WEAPON_PISTOL, 1000);
		this->m_nActiveWeaponSlot = 0;
		this->m_fArmour = 0.0f;
		this->m_nWeaponShootingRate = 30;
		this->m_nWeaponAccuracy = 60;
		break;
	case COP_TYPE_LAPDM1:
		this->SetModelIndex(MODEL_LAPDM1);
		this->GiveWeapon(WEAPON_NIGHTSTICK, 1000, true);
		this->GiveDelayedWeapon(WEAPON_PISTOL, 1000);
		this->m_nActiveWeaponSlot = 0;
		this->m_fArmour = 0.0f;
		this->m_nWeaponShootingRate = 30;
		this->m_nWeaponAccuracy = 60;
		break;
	case COP_TYPE_SWAT1:
	case COP_TYPE_SWAT2:
		this->SetModelIndex(MODEL_SWAT);
		this->GiveDelayedWeapon(WEAPON_MICRO_UZI, 1000);
		this->SetCurrentWeapon(WEAPON_MICRO_UZI);
		this->m_fArmour = 50.0f;
		this->m_nWeaponShootingRate = 70;
		this->m_nWeaponAccuracy = 68;
		break;
	case COP_TYPE_FBI:
		this->SetModelIndex(MODEL_FBI);
		this->GiveDelayedWeapon(WEAPON_MP5, 1000);
		this->SetCurrentWeapon(WEAPON_MP5);
		this->m_fArmour = 100.0f;
		this->m_nWeaponShootingRate = 60;
		this->m_nWeaponAccuracy = 76;
		break;
	case COP_TYPE_ARMY:
		this->SetModelIndex(MODEL_ARMY);
		this->GiveDelayedWeapon(WEAPON_M4, 1000);
		this->SetCurrentWeapon(WEAPON_M4);
		this->m_fArmour = 100.0f;
		this->m_nWeaponShootingRate = 80;
		this->m_nWeaponAccuracy = 84;
		break;
	case COP_TYPE_CSHER:
		this->SetModelIndex(MODEL_CSHER);
		this->GiveWeapon(WEAPON_NIGHTSTICK, 1000, true);
		this->GiveDelayedWeapon(WEAPON_PISTOL, 1000);
		this->m_nActiveWeaponSlot = 0;
		this->m_fArmour = 0.0f;
		this->m_nWeaponShootingRate = 30;
		this->m_nWeaponAccuracy = 60;
		break;
	default:
		this->SetModelIndex(copType);
		this->GiveWeapon(WEAPON_NIGHTSTICK, 1000, true);
		this->GiveDelayedWeapon(WEAPON_PISTOL, 1000);
		this->m_nActiveWeaponSlot = 0;
		this->m_fArmour = 0.0f;
		this->m_nWeaponShootingRate = 30;
		this->m_nWeaponAccuracy = 60;
	}
	this->field_79C = 0;
	this->field_74C = 0;
	this->field_7A4 = 0;
	CEntity *entity = this->m_pTargetedObject;
	if (this->m_pTargetedObject)
		this->m_pTargetedObject->CleanUpOldReference(&entity);
	this->m_pTargetedObject = nullptr;
	((void (__thiscall *)(CAEPedSpeechAudioEntity *, CPed *))0x4E68D0)(&this->m_pedSpeech, this); // CAEPedSpeechAudioEntity::Initialise(CPed *)
	this->m_pIntelligence->m_fDmRadius = 60.0f;
	this->m_pIntelligence->m_nDmNumPedsToScan = 8;
	this->m_pCopPartner = 0;
	this->m_apCriminalsToKill[0] = nullptr;
	this->m_apCriminalsToKill[1] = nullptr;
	this->m_apCriminalsToKill[2] = nullptr;
	this->m_apCriminalsToKill[3] = nullptr;
	this->m_apCriminalsToKill[4] = nullptr;
	this->field_7C0 = 0;
}

// _CopPed.cpp

#include "plugin.h"
#include "CCopPed.h"

using namespace plugin;

template <typename T>
void * GetMethod(T TMethod) // return void * __thiscall function
{
	union
	{
		T TValue;
		void * Address;
	} retn = {TMethod};
	return retn.Address;
}

class _CopPed {
public:
	_CopPed() {
		Events::gameProcessEvent += [] {
			patch::RedirectJump(0x5DDC60, GetMethod(&CCopPed::_CCopPed));
		};
    }
} _copPed;

Edited December 4, 2018 by Dyabda

[The Hero]

I guess you should find out WHERE it crashes and see how that happened. Personally, instead of casting sh*t to thiscalls all the time I just declare the classes (as dummies if necessary) a the methods I'm using.