is this cleo script efficient?

[frankandbeans]

I modified a simple scm/cleo script from this link: https://www.gtamodding.com/wiki/020A in order to have the rhino, hydra, or hunter become automatically locked when the player enters inside. I wanted to know if my modified script is efficient for performance since I removed the check for key press from the original script, making the game constantly checking for the three vehicles. Could I make this script perform better? Maybe add more 'wait' somewhere?

 

note: I chose the three vehicles because they remain open when leaving them, so 'Car.DoorStatus([email protected]) = 2' works nicely here I believe.

{$CLEO .cs}//-------------MAIN---------------0000: NOP :NONAME_2wait 10 if    Player.Defined($PLAYER_CHAR)jf @NONAME_2 if    Actor.Driving($PLAYER_ACTOR)jf @NONAME_2 [email protected] = Actor.CurrentCar($PLAYER_ACTOR)if or   Car.Id([email protected]) == #RHINO    Car.Id([email protected]) == #HYDRA    Car.Id([email protected]) == #HUNTERjf @NONAME_2 Car.DoorStatus([email protected]) = 2jump @NONAME_2 

Edited January 4, 2018 by frankandbeans

[Silent]

Efficiency is not really a thing you should worry about here. You'd get away with checking it every 250ms too or so.

[frankandbeans]

Efficiency is not really a thing you should worry about here. You'd get away with checking it every 250ms too or so.

Oh okay. I guess the script is really simple eh? I'll try increasing ms then. Thanks for your input.

 

Off-topic: can't wait for your next Silent Patch for SA (vehicle features!).

[frankandbeans]

 

Efficiency is not really a thing you should worry about here. You'd get away with checking it every 250ms too or so.

Oh okay. I guess the script is really simple eh? I'll try increasing ms then. Thanks for your input.

 

Off-topic: can't wait for your next Silent Patch for SA (vehicle features!).

edit: I initially posted this because I thought the script made my game lag, but it was the 333mb file in the Mod Loader that made me lag instead.

 

edit2: Accidently clicked 'Quote' instead of 'Edit'...

Edited January 5, 2018 by frankandbeans