Quantcast
Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
    1. Welcome to GTAForums!

    2. News

    1. Red Dead Redemption 2

      1. Gameplay
      2. Missions
      3. Help & Support
    2. Red Dead Online

      1. Gameplay
    1. GTA Online

      1. After Hours
      2. Find Lobbies & Players
      3. Guides & Strategies
      4. Vehicles
      5. Content Creator
      6. Help & Support
    2. Crews

      1. Events
      2. Recruitment
    1. Grand Theft Auto Series

    2. GTA Next

    3. GTA V

      1. PC
      2. Guides & Strategies
      3. Help & Support
    4. GTA IV

      1. Episodes from Liberty City
      2. Multiplayer
      3. Guides & Strategies
      4. Help & Support
      5. GTA Mods
    5. GTA Chinatown Wars

    6. GTA Vice City Stories

    7. GTA Liberty City Stories

    8. GTA San Andreas

      1. Guides & Strategies
      2. Help & Support
      3. GTA Mods
    9. GTA Vice City

      1. Guides & Strategies
      2. Help & Support
      3. GTA Mods
    10. GTA III

      1. Guides & Strategies
      2. Help & Support
      3. GTA Mods
    11. Top Down Games

      1. GTA Advance
      2. GTA 2
      3. GTA
    12. Wiki

      1. Merchandising
    1. GTA Modding

      1. GTA V
      2. GTA IV
      3. GTA III, VC & SA
      4. Tutorials
    2. Mod Showroom

      1. Scripts & Plugins
      2. Maps
      3. Total Conversions
      4. Vehicles
      5. Textures
      6. Characters
      7. Tools
      8. Other
      9. Workshop
    3. Featured Mods

      1. DYOM
      2. OpenIV
      3. GTA: Underground
      4. GTA: Liberty City
      5. GTA: State of Liberty
    1. Red Dead Redemption

    2. Rockstar Games

    1. Off-Topic

      1. General Chat
      2. Gaming
      3. Technology
      4. Programming
      5. Movies & TV
      6. Music
      7. Sports
      8. Vehicles
    2. Expression

      1. Graphics / Visual Arts
      2. GFX Requests & Tutorials
      3. Writers' Discussion
      4. Debates & Discussion
    1. Forum Support

    2. Site Suggestions

Sign in to follow this  
The_GTA

Contribution to open source projects...

Recommended Posts

The_GTA

I have had experience with three open source projects where I created pull-requests to. My conclusion is that doing so is a big hassle.

 

Example #1: AsmJIT

https://github.com/asmjit/asmjit/pull/173

 

Purpose:

I created an addon to the AsmJIT assembly generation framework which gave feedback about memory-location-sensity assembly output so that it could be fixed up. With this power I can create /DYNAMICBASE style PE executables from assembly.

 

My experience:

The author of AsmJIT entangled me into a discussion where he wanted to work on an text assembler. He claimed that my work had to be compatible with his vision before it were merged. Thus my pull is forever pending.

 

Example #2: Compressonator

https://github.com/GPUOpen-Tools/Compressonator/pull/23

 

Purpose:

Added support for Linux operating system.

 

My experience:

The commercial guys at AMD, one of which is Navin Patel, have been pretty busy with things. Unfortunately they have never finished evaluating my pull request which is weird. I would assume that working code should be merged and one could easily work based on it. Since I am a student who just did it for fun I am stressed but will look how to get this up-to-date.

 

Example #3: SAO

​pull request is ripperoni in pepperoni

 

Purpose:

Contribution of my PE executable parsing framework (PEframework) for SAO game loading so that everything was nicely documented.

 

My experience:

iFarbod was not convinced of the necessity of my code so he declined it. I can fully understand that he wanted to do it himself to learn so I let it pass by. Not really sure if he had any code quality objections for my work. I was sort of disappointed. But okay.

 

------------------------

 

Conclusion: think twice before you get into this hassle. :)

Share this post


Link to post
Share on other sites
K^2

Yeah, open source contribs often go that way. We're using a few open source libraries at work. At least two of my co-workers have tried getting bug fixes we had to make pulled into main branch with variable success. But it's always going to be some amount of hassle and red-tape on a project made up of more than one person.

 

Personally, I've ran into something very similar while working at Google with the internal code. Any fixes I had to put into other team's libraries would go through more scrutiny than they often deserved. My favorite example is when I've spotted that leap seconds counter wasn't updated for the most recent leap second in one of the libraries I was considering to use. Scope of the project: Increment integer by one. Time to get approved: Two weeks and three revisions.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

  • 1 User Currently Viewing
    0 Members, 0 Anonymous, 1 Guest

×

Important Information

By using GTAForums.com, you agree to our Terms of Use and Privacy Policy.